[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
Re: Adding UMO versions
Aha. Sounds right. Your latest changes fixed the problem.
Alexey Parshin wrote:
> Ok, figure out the reason :)
>
> The permissions seem to be ok. However, is_authorized() function has
> an extra piece of logic:
> If the UMO is published and attempted permission involves data
> modification - then this permission is always blocked.
>
> Now, the 'modifies data' flag is defined in access_name table, and is
> TRUE for Add Version. I think, it's probably logical to switch it to
> FALSE (since we aren't modifying an existing data but adding new one)
> and this would make Add Version work as expected:
>
> update access_name set an_modifies_data = 'f' where an_id = 5;
>
> 2009/1/5 Alexey Parshin <alexeyp@gmail.com <mailto:alexeyp@gmail.com>>
>
> Ok, will do tonight (in ~5-6 hrs)
>
>
> 2009/1/5 Ilya A. Volynets-Evenbakh <ilya@total-knowledge.com
> <mailto:ilya@total-knowledge.com>>
>
> Top.
>
> Alexey Parshin wrote:
> > Define the priority for this.
> >
> > 2009/1/5 Ilya A. Volynets-Evenbakh <ilya@total-knowledge.com
> <mailto:ilya@total-knowledge.com>
> > <mailto:ilya@total-knowledge.com
> <mailto:ilya@total-knowledge.com>>>
> >
> > Alexey Parshin wrote:
> > > 1. As far as I can see, umo_create() calls
> > umo_create_default_groups()
> > > .. (pseudo-calls!):
> > >
> > > umo_create() --> umo_create_default_groups() -->
> > > person_add_to_group('ADMINS'), acl_grant('ADMINS','...,ADD
> > VERSION,...');
> > Can you develop a test case in database for umo_create +
> publish and
> > then umo_add_version?
> > I think the one you have creates new version for
> unpublished UMO
> > (Hmm..
> > Should we even allow that?)
> > >
> > > So, the object creator is inserted into Admins group
> that has 'Add
> > > Version' right. May be, something is wrong with a
> version of UMO
> > > created with umo_create_version?
> > >
> > > 2. There could be one or more contents for each UMO
> (one per
> > > language). Content_id is an id of the particular content
> > translation.
> > >
> > Mm... I guess creating version first would be better then.
> >
> > Ilya.
> >
>