Home Projects Jobs Clientele Contact


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Review of latest code

I finally started reviewing code.
First thing that caught my eye:


string csp = "HomeView.csp";
RequestDispatcher* destination = request.getRequestDispatcher(csp);

This contradicts tech spec:
Template organization
Template mappings
Templates (CSP pages) will have identical names, and will be mapped to subdirectories named based on theme.

Now, HomeView.csp itself.
Currently it's doing lot of data retrieval work from DB.
This sort of conflicts with the original idea of having all data retrieval be done from a servlet,
and passing the data as request attributes.
(This, by the way, would prevent your exception handling problem we discussed on IRC).


Authoright © Total Knowledge: 2001-2008