[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
Re: [PATCH] Added test functionality for Util.h servlet
1. Bits to add new servlet seem to be missing
- Top-level Makefile.adon
- engine.xml
2. opening form in service() method, but closing it in utilFooter()
seems to be asymmetric
3. Let's follow conventions of other samples, and use renderHeader &
renderFooter
names with same signatures as other samples. One day we'll abstract them
out, and make one common base servlet class that'll hold these, and
use it
for all servlets.
Looks good otherwise.
--
Ilya A. Volynets-Evenbakh
Total Knowledge. CTO
http://www.total-knowledge.com